Skip to content

Add tests for stream group crud functions#93

Merged
das-Abroxas merged 2 commits intodevfrom
test/internal-notification-crud
Jul 5, 2023
Merged

Add tests for stream group crud functions#93
das-Abroxas merged 2 commits intodevfrom
test/internal-notification-crud

Conversation

@das-Abroxas
Copy link
Copy Markdown
Contributor

This PR adds a basic set of tests for the CRUD database functions which were implemented with the InternalNotificationService. To ensure the stability and consistency requirements of the AOS, tests are of course essential. Therefore, these will be provided as soon as possible if they were not delivered directly with a service implementation.

@das-Abroxas das-Abroxas added the enhancement New feature or request label Jul 3, 2023
@das-Abroxas das-Abroxas added this to the v1.1.0 milestone Jul 3, 2023
@das-Abroxas das-Abroxas requested review from St4NNi and lfbrehm July 3, 2023 13:45
@das-Abroxas das-Abroxas self-assigned this Jul 3, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.54 🎉

Comparison is base (dd56ae6) 54.19% compared to head (40dbd36) 54.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #93      +/-   ##
==========================================
+ Coverage   54.19%   54.73%   +0.54%     
==========================================
  Files          48       48              
  Lines       10566    10567       +1     
==========================================
+ Hits         5726     5784      +58     
+ Misses       4840     4783      -57     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@St4NNi St4NNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@das-Abroxas das-Abroxas merged commit 041e5ff into dev Jul 5, 2023
@St4NNi St4NNi deleted the test/internal-notification-crud branch August 29, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants