Feat/version2.0 user requests#98
Merged
lfbrehm merged 8 commits intofeat/version2.0reworkfrom Aug 8, 2023
Merged
Conversation
…/version2.0_user_requests
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/version2.0rework #98 +/- ##
=========================================================
- Coverage 21.23% 19.40% -1.84%
=========================================================
Files 43 48 +5
Lines 3758 4268 +510
=========================================================
+ Hits 798 828 +30
- Misses 2960 3440 +480
☔ View full report in Codecov by Sentry. |
St4NNi
approved these changes
Aug 8, 2023
| ); | ||
| let (user_id, user) = tonic_internal!( | ||
| self.database_handler.activate_user(request).await, | ||
| "Internal deactivate user error" |
| return_with_log!(response); | ||
| } | ||
|
|
||
| async fn get_api_tokens( |
Member
There was a problem hiding this comment.
Shouldn´t this be easy to do as-well ? Since the tokens are now part of a user this should be quite straight forward.
| return_with_log!(DeleteApiTokenResponse {}); | ||
| } | ||
|
|
||
| async fn delete_api_tokens( |
|
|
||
| impl DatabaseHandler { | ||
| pub async fn create_token(&self) { | ||
| todo!() |
Member
There was a problem hiding this comment.
On a database perspective this is straight, forward, create the token (with uuid) and add it to the jsonb attributes of the user
| let user = User::get(id, client) | ||
| .await? | ||
| .ok_or_else(|| anyhow!("User not found"))?; | ||
| transaction.commit().await?; |
| let user = User::get(id, client) | ||
| .await? | ||
| .ok_or_else(|| anyhow!("User not found"))?; | ||
| transaction.commit().await?; |
| let user = User::get(user_id, client) | ||
| .await? | ||
| .ok_or_else(|| anyhow!("User not found"))?; | ||
| transaction.commit().await?; |
| let user = User::get(user_id, client) | ||
| .await? | ||
| .ok_or_else(|| anyhow!("User not found"))?; | ||
| transaction.commit().await?; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds basic functionality for grpc-side user requests.