Refactor credentials modal #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
das-Abroxas
added
enhancement
St4NNi
approved these changes
Oct 2, 2024
Member
St4NNi
left a comment
St4NNi
left a comment
There was a problem hiding this comment.
LGTM. Does this also move to a props based state handling for this modal ? On the quick skim through it looked like it does.
Contributor
Author
|
Yep. The shadcn dialog components visibility can be completely handled by reactive properties. Makes life so much easier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a refactor of the modal which displays the user's S3 credentials after fetching/creation and toast display components, transitioning from Preline-based implementations to shadcn-vue for improved consistency and maintainability. Additionally, several dependency versions have been updated to ensure compatibility and take advantage of the latest improvements and security patches.