Fix mailing list registration #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presumably due to the combination of the ofetch library and the Bun JavaScript runtime the POST request failed with elusive errors. This is solved by using the Bun native fetch implementation for the request.
St4NNi
approved these changes
Jul 11, 2024
Member
St4NNi
left a comment
St4NNi
left a comment
There was a problem hiding this comment.
Weird issue, the intricacies between fetch and $fetch is really weird.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue with the mailing list subscription form that was failing to submit due to elusive errors, presumably caused by the combination of the ofetch library and the Bun JavaScript runtime. The fix involves replacing the ofetch library with JavaScript runtime's native fetch implementation for these specific requests, restoring the form's functionality.