Skip to content

Conversation

@GlauberF
Copy link

Descrição

Esse PR faz merge da branch release para a branch master_base, aplicando as atualizações da biblioteca.

PR Relacionadas

Link da tarefa no JIRA

Serviços afetados

Prints do desenvolvimento

This comment was marked as outdated.

@danielrbrdan danielrbrdan requested a review from Copilot August 12, 2025 14:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges the release branch into the master_base branch, updating the Java NFe library to version 4.00.41. The update includes new test classes for various NFe printing functionalities and two new JasperReports templates.

  • Addition of comprehensive test examples for NFe, NFCe, CCe, HTML, PDF, and Jasper printing functionality
  • Introduction of new JasperReports templates for NFe invoice printing (DANFE) and NFCe consumer receipt printing
  • Update to support modern printing requirements with enhanced layout and field handling

Reviewed Changes

Copilot reviewed 30 out of 37 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
TesteImpressaoPdfByte.java Test class for PDF byte array generation from NFe XML
TesteImpressaoPdfArquivo.java Test class for PDF file generation from NFe XML
TesteImpressaoNFe.java Test class for standard NFe PDF printing
TesteImpressaoNFCe.java Test class for NFCe PDF printing with URL consultation
TesteImpressaoJasperPreview.java Test class for Jasper preview functionality
TesteImpressaoHtml.java Test class for HTML generation from NFe XML
TesteImpressaoCCe.java Test class for CCe (Carta de Correção) PDF printing
danfe_fatura.jrxml JasperReports template for invoice/duplicate printing in NFe
danfe.jrxml Main JasperReports template for DANFE (NFe auxiliary document)
danfce.jrxml JasperReports template for DANFCE (NFCe auxiliary document)

ImpressaoDTO impressao = ImpressaoNfeUtil.impressaoPadraoNFe(xml);

//Faz a impressão em pdf File passando o caminho do Arquivo
ImpressaoNfeUtil.impressaoPdfArquivo(impressao, "/d/teste/teste-nfe.pdf");
Copy link

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file path uses an inconsistent format compared to other test files. This file uses "/d/teste/" while others use "d:/teste/". Consider standardizing the path format across all test files for consistency.

Suggested change
ImpressaoNfeUtil.impressaoPdfArquivo(impressao, "/d/teste/teste-nfe.pdf");
ImpressaoNfeUtil.impressaoPdfArquivo(impressao, "d:/teste/teste-nfe.pdf");

Copilot uses AI. Check for mistakes.
public static void main(String[] args) {
try {
//Faça a leitura do Arquivo
String xml = XmlNfeUtil.leXml("D:\\teste\\nfe.xml");
Copy link

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file path uses Windows-style backslashes (D:\teste\) while other test files use forward slashes (d:/teste/). Consider standardizing the path format across all test files for consistency and cross-platform compatibility.

Suggested change
String xml = XmlNfeUtil.leXml("D:\\teste\\nfe.xml");
String xml = XmlNfeUtil.leXml("D:/teste/nfe.xml");

Copilot uses AI. Check for mistakes.
//Faz a impressão e retorna um Jasper Preview
JasperViewer jasperViewer = ImpressaoNfeUtil.impressaoPreview(impressao);

//PAra mostrar o Preview
Copy link

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the comment: 'PAra' should be 'Para'.

Suggested change
//PAra mostrar o Preview
//Para mostrar o Preview

Copilot uses AI. Check for mistakes.
@GlauberF GlauberF merged commit 9e8c30c into master_base Aug 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants