Fix Coverage.py configuration #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the default configuration was running coverage on our code-base but also on the dependencies, giving us a quite poor coverage score (~40%). With this configuration, the coverage takes only into account our source code (which is, obviously, what we care about). We then have a decent coverage score of 97%.
Collaborator
|
@frankie567 Awesome coverage improvement! This is great. Make as many PRs to the library as you like! It doesn't bother me at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @avelis,
I hope I don't bother you too much with all my PRs! This is just a small configuration fix.
Currently, the default configuration was running coverage on our code-base but also on the dependencies, giving us a quite poor coverage score (~40%).
With this configuration, the coverage takes only into account our source code (which is, obviously, what we care about). We then have a decent coverage score of 97%.
Best regards!