Skip to content

Conversation

@ascopes
Copy link
Owner

@ascopes ascopes commented Oct 30, 2022

No description provided.

@ascopes ascopes added new feature A new feature enhancement Optimisations and internal improvements in the codebase. labels Oct 30, 2022
@ascopes ascopes added this to the 1.0.0 milestone Oct 30, 2022
@ascopes ascopes self-assigned this Oct 30, 2022
*/
public RamFileSystem copiedFromUrl(URL url) {
public I copiedFromUrl(URL url) {
return uncheckedIo(() -> createFile(url.openStream()));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLCONNECTION_SSRF_FD: This web server request could be used by an attacker to expose internal services and filesystem.


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant as this is part of a test pack only.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonatype-lift ignore

@sonatype-lift
Copy link

sonatype-lift bot commented Oct 30, 2022

⚠️ 3 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@ascopes ascopes merged commit a607df3 into main Oct 30, 2022
@ascopes ascopes deleted the task/128-temp-fs branch October 30, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Optimisations and internal improvements in the codebase. new feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants