Skip to content

Rethrow assumption failures #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Rethrow assumption failures #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d23487
Add opentest4j dependency
ascopes Nov 21, 2022
e1ec029
Rethrow org.opentest4j.TestAbortedException
ascopes Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...compiler-testing/src/main/java/io/github/ascopes/jct/junit/AbstractCompilersProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.junit.jupiter.api.extension.ExtensionContext;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.ArgumentsProvider;
import org.opentest4j.TestAbortedException;

/**
* Base for defining a compiler-supplying arguments provider for Junit Jupiter parameterised test
Expand Down Expand Up @@ -124,7 +125,7 @@ private void applyConfigurers(JctCompiler<?, ?> compiler) {
for (var configurerClass : configurerClasses) {
try {
initialiseConfigurer(configurerClass).configure(compiler);
} catch (AssertionError ex) {
} catch (TestAbortedException ex) {
throw ex;
} catch (Exception ex) {
throw new JctJunitConfigurerException(
Expand Down
1 change: 1 addition & 0 deletions java-compiler-testing/src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
requires static transitive org.apiguardian.api;
requires org.assertj.core;
requires static transitive org.junit.jupiter.params;
requires static org.opentest4j;
requires org.slf4j;

// Annotations is internal, but we export it for documentation purposes.
Expand Down