Skip to content

Enable manifold warning preprocessor test #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Enable manifold warning preprocessor test #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6dd0b2
Enable manifold warning preprocessor test
ascopes Nov 23, 2022
7e4d112
Update pom.xml
ascopes Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion acceptance-tests/acceptance-tests-manifold-systems/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
<artifactId>maven-surefire-plugin</artifactId>

<configuration>
<failIfNoTests>true</failIfNoTests>
<failIfNoTests>false</failIfNoTests>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 0 additions & 2 deletions ...rc/test/groovy/io/github/ascopes/acceptancetests/manifold/ManifoldPreprocessorTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ package io.github.ascopes.acceptancetests.manifold

import io.github.ascopes.jct.compilers.JctCompiler
import io.github.ascopes.jct.junit.JavacCompilerTest
import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.DisplayName

import static io.github.ascopes.jct.assertions.JctAssertions.assertThatCompilation
Expand Down Expand Up @@ -84,7 +83,6 @@ class ManifoldPreprocessorTest {
assertThat(greeting).isEqualTo("Hello, World! (symbol was not defined)")
}

@Disabled("See https://github.com/manifold-systems/manifold/issues/399")
@DisplayName("Warning directives produce compiler warnings in JCT")
@JavacCompilerTest(configurers = [ManifoldPluginConfigurer])
void warningDirectivesProduceCompilerWarningsInJct(JctCompiler compiler) {
Expand Down