Skip to content

Conversation

@ascopes
Copy link
Owner

@ascopes ascopes commented Dec 18, 2022

Contributes to #200 to add more acceptance tests.

This currently adds:

  • Google Error Prone
  • Avaje Inject

@ascopes ascopes added testing Improvements to test packs 👕 medium labels Dec 18, 2022
@ascopes ascopes added this to the 1.0.0 milestone Dec 18, 2022
@ascopes ascopes self-assigned this Dec 18, 2022
@ascopes ascopes force-pushed the task/200-more-acceptance-tests branch 3 times, most recently from 9aae276 to 5335090 Compare December 18, 2022 14:58
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Merging #201 (8f343bc) into main (8f343bc) will not change coverage.
The diff coverage is n/a.

❗ Current head 8f343bc differs from pull request most recent head 5335090. Consider uploading reports for the commit 5335090 to get more accurate results

@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   61.59%   61.59%           
=======================================
  Files          70       70           
  Lines        2466     2466           
  Branches      229      229           
=======================================
  Hits         1519     1519           
  Misses        859      859           
  Partials       88       88           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Dec 18, 2022

Test Results

     730 files  +  26       730 suites  +26   6s ⏱️ -1s
12 756 tests +299  12 680 ✔️ +299  76 💤 ±0  0 ±0 
13 016 runs  +299  12 940 ✔️ +299  76 💤 ±0  0 ±0 

Results for commit 73630e8. ± Comparison against base commit a76ce28.

♻️ This comment has been updated with latest results.

@ascopes ascopes force-pushed the task/200-more-acceptance-tests branch from 5335090 to e025466 Compare December 22, 2022 07:53
@ascopes ascopes force-pushed the task/200-more-acceptance-tests branch from e025466 to 73630e8 Compare December 22, 2022 07:55
@ascopes ascopes marked this pull request as ready for review December 22, 2022 08:17
@ascopes ascopes merged commit 943e79e into main Dec 22, 2022
@ascopes ascopes deleted the task/200-more-acceptance-tests branch December 22, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Improvements to test packs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants