Skip to content

Conversation

@ascopes
Copy link
Owner

@ascopes ascopes commented Dec 30, 2022

  • Use surefire for unit tests in main module.
  • Use failsafe for integration tests in main module.
  • Use separate JaCoCo report for unit tests.
  • Use separate JaCoCo report for integration tests.
  • Rework mutation test skippage annotation in main module.
  • Instruct JaCoCo to run on verify phase as well as test phase.
  • Implement codecov feature flags for integration and unit tests individually.
  • Skip running test runner at all for Manifold when on <jdk>(11,)</jdk> similar to what Spring does for <jdk>[,15)</jdk>
  • Rewrite parts of prepare-test-outputs-for-merge.sh to cope with new report locations.

Closes #122.

@ascopes ascopes added housekeeping testing Improvements to test packs ci Changes to CI workflows maven Changes within Maven manifests labels Dec 30, 2022
@ascopes ascopes added this to the 1.0.0 milestone Dec 30, 2022
@ascopes ascopes self-assigned this Dec 30, 2022
@github-actions
Copy link

Test Results

  1 302 files   -   13    1 302 suites   - 13   4s ⏱️ ±0s
17 138 tests  -   46  17 062 ✔️  -   46  76 💤 ±0  0 ±0 
18 796 runs   - 126  18 720 ✔️  - 126  76 💤 ±0  0 ±0 

Results for commit 4b86d22. ± Comparison against base commit e633882.

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Merging #217 (1ec5e6b) into main (e633882) will not change coverage.
The diff coverage is n/a.

❗ Current head 1ec5e6b differs from pull request most recent head 05c366b. Consider uploading reports for the commit 05c366b to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   67.68%   67.68%           
=======================================
  Files          70       70           
  Lines        2448     2448           
  Branches      226      226           
=======================================
  Hits         1657     1657           
  Misses        723      723           
  Partials       68       68           

@ascopes ascopes force-pushed the task/122-unit-and-integration-tests branch from fa94e47 to 8d87d61 Compare December 30, 2022 14:13
@ascopes
Copy link
Owner Author

ascopes commented Dec 30, 2022

Spotted and reported fabriciorby/maven-surefire-junit5-tree-reporter#29 as part of this PR, but this is not impacting builds currently.

@ascopes ascopes force-pushed the task/122-unit-and-integration-tests branch 3 times, most recently from 1ec5e6b to 27d537d Compare December 30, 2022 14:22
@ascopes ascopes force-pushed the task/122-unit-and-integration-tests branch from 27d537d to 011c631 Compare December 30, 2022 14:22
@ascopes ascopes merged commit 8eeba14 into main Dec 30, 2022
@ascopes ascopes deleted the task/122-unit-and-integration-tests branch December 30, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Changes to CI workflows maven Changes within Maven manifests testing Improvements to test packs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split up unit tests and integration tests in main module

3 participants