Skip to content

Conversation

@ascopes
Copy link
Owner

@ascopes ascopes commented Jan 21, 2023

Removes the -implicit flag from the default compilation settings
for Javac, as it may hide potential compilation bugs.

@ascopes ascopes added this to the First Stable Release (v0.0.1) milestone Jan 21, 2023
@ascopes ascopes self-assigned this Jan 21, 2023
@github-actions
Copy link

Test Results

  1 448 files  ±  0    1 448 suites  ±0   0s ⏱️ ±0s
18 025 tests +26  18 025 ✔️ +26  0 💤 ±0  0 ±0 
18 311 runs  +26  18 311 ✔️ +26  0 💤 ±0  0 ±0 

Results for commit c917db8. ± Comparison against base commit 3781d6e.

@codecov-commenter
Copy link

Codecov Report

Merging #264 (c917db8) into main (3781d6e) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
- Coverage   70.91%   70.89%   -0.02%     
==========================================
  Files          72       72              
  Lines        2537     2536       -1     
  Branches      237      237              
==========================================
- Hits         1799     1798       -1     
  Misses        671      671              
  Partials       67       67              
Impacted Files Coverage Δ
...opes/jct/compilers/javac/JavacJctCompilerImpl.java 100.00% <ø> (ø)

@ascopes ascopes merged commit 313141f into main Jan 21, 2023
@ascopes ascopes deleted the task/remove-implicit branch January 21, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants