Skip to content

Remove -implicit flag from default compilation #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Remove -implicit flag from default compilation #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ler-testing/src/main/java/io/github/ascopes/jct/compilers/javac/JavacJctCompilerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ public JavacJctCompilerImpl(String name) {
*/
public JavacJctCompilerImpl(String name, JavaCompiler jsr199Compiler) {
super(name, jsr199Compiler, new JavacJctFlagBuilderImpl());
addCompilerOptions("-implicit:class");
}

@Override
Expand Down
20 changes: 17 additions & 3 deletions .../test/java/io/github/ascopes/jct/tests/unit/compilers/javac/JavacJctCompilerImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,25 @@ void compilersHaveTheExpectedFlagBuilder() {
assertThat(compiler.getFlagBuilder()).isInstanceOf(JavacJctFlagBuilderImpl.class);
}

@DisplayName("compilers have the -implicit:class flag set")
@DisplayName("Compilers have no default compiler flags set")
@Test
void compilersHaveTheImplicitClassFlagSet() {
void compilersHaveNoDefaultCompilerFlagsSet() {
// Then
assertThat(compiler.getCompilerOptions()).contains("-implicit:class");
assertThat(compiler.getCompilerOptions()).isEmpty();
}

@DisplayName("Compilers have no default annotation processor flags set")
@Test
void compilersHaveNoDefaultAnnotationProcessorFlagsSet() {
// Then
assertThat(compiler.getAnnotationProcessorOptions()).isEmpty();
}

@DisplayName("Compilers have no default annotation processors set")
@Test
void compilersHaveNoDefaultAnnotationProcessorsSet() {
// Then
assertThat(compiler.getAnnotationProcessors()).isEmpty();
}

@DisplayName("compilers have the expected default release string")
Expand Down