Skip to content

Conversation

@ascopes
Copy link
Owner

@ascopes ascopes commented May 27, 2023

  • Deprecate PathFileObject#getFullPath for removal in v1.0.0 as it is not immediately clear
    what a "full path" means.
  • Implement PathFileObject#getAbsolutePath to replace PathFileObject#getFullPath
  • Implement PathFileObject assertion tests.

ascopes added 2 commits May 27, 2023 09:56
Create PathFileObject#getAbsolutePath and make it return the same thing as
PathFileObject#getFullPath. I have then deprecated PathFileObject#getFullPath
as the naming is not completely clear as to what a 'full path' implies. This
will be removed in 1.0.0.
@ascopes ascopes added housekeeping testing Improvements to test packs labels May 27, 2023
@ascopes ascopes added this to the 100% test coverage milestone May 27, 2023
@ascopes ascopes self-assigned this May 27, 2023
@ascopes ascopes merged commit 7081dae into main May 27, 2023
@ascopes ascopes deleted the task/path-assertions branch May 27, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Improvements to test packs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants