Skip to content

feat(cli): 1Password save and UX improvements for generated passwords#139

Merged
ascorbic merged 3 commits intomainfrom
feat/cli-generate-password
Mar 15, 2026
Merged

feat(cli): 1Password save and UX improvements for generated passwords#139
ascorbic merged 3 commits intomainfrom
feat/cli-generate-password

Conversation

@ascorbic
Copy link
Copy Markdown
Owner

Summary

  • Don't print generated passwords to the terminal by default — only as a last resort when clipboard is unavailable
  • When generating a password, prompt where to save it: 1Password (as a bsky.app login), clipboard, or display
  • 1Password option only shown when op CLI is detected
  • Falls back gracefully: 1Password failure → clipboard → display

Builds on #137.

Test plan

  • Run pds init, choose "Generate one automatically", verify 1Password option appears (if op installed)
  • Choose 1Password — verify Login item created with handle as username and bsky.app URL
  • Choose clipboard — verify password copied, not displayed
  • Choose display — verify password shown in terminal
  • Run without op CLI — verify only clipboard/display options shown

When generating a password, prompt where to save it: 1Password
(as a bsky.app login), clipboard, or display. 1Password option
only shown when op CLI is available.
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
atproto-pds b64acc0 Mar 15 2026, 10:02 PM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 15, 2026

Open in StackBlitz

npm i https://pkg.pr.new/create-pds@139
npm i https://pkg.pr.new/@getcirrus/oauth-provider@139
npm i https://pkg.pr.new/@getcirrus/pds@139

commit: b64acc0

@ascorbic ascorbic merged commit 84c2e22 into main Mar 15, 2026
5 checks passed
@ascorbic ascorbic deleted the feat/cli-generate-password branch March 15, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant