chore(pds): extract invalidRecordError helper in repo.ts#17
Merged
Conversation
Replaces empty validator with actual schema validation using official
Bluesky lexicon JSON files vendored from the atproto repository.
Changes:
- Added update-lexicons.sh script to fetch official schemas from GitHub
- Vendored 16 lexicon schemas (core, feed, actor, graph, richtext, embed)
- Updated validation.ts to load all schemas with proper dependencies
- Added 11 Bluesky-specific validation tests (all passing)
- Tree-shakeable: only JSON files imported, no large dependencies
Schemas loaded:
- Core: com.atproto.repo.strongRef, com.atproto.label.defs
- Feed: app.bsky.feed.{post, like, repost, threadgate}
- Actor: app.bsky.actor.profile
- Graph: app.bsky.graph.{follow, block, list, listitem}
- Richtext: app.bsky.richtext.facet
- Embed: app.bsky.embed.{images, external, record, recordWithMedia}
All 19 tests passing (8 validation tests + 11 Bluesky tests).
- Use LexiconDoc type instead of any in validation.ts - Add vite/client types to tsconfig for import.meta.glob - Format firehose test and add proper sequencer typing - Remove unused echo from update-lexicons script - Remove unused dependencies from lockfile 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Reduces duplication for InvalidRecord error responses across createRecord, putRecord, and applyWrites endpoints. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
atproto-pds | f817d84 | Dec 28 2025, 07:38 AM |
ascorbic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces duplication for InvalidRecord error responses across
createRecord, putRecord, and applyWrites endpoints.
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com