feat(pds): implement PDS-side identity endpoints#179
Merged
Conversation
Adds three com.atproto.identity.* endpoints that previously fell through
to the AppView proxy and returned 501:
- resolveDid: returns the local DID document for our DID
- resolveIdentity: returns {did, handle, didDoc} for our DID or handle
- getRecommendedDidCredentials: returns rotation keys, alsoKnownAs,
verification methods, and PDS service entry for inbound migration
Foreign DIDs and handles still fall through to the AppView proxy.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
pdscheck | 43f7a9c | May 24 2026, 07:55 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
atproto-pds | 43f7a9c | May 24 2026, 07:55 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cirrusdocs | 43f7a9c | Commit Preview URL Branch Preview URL |
May 24 2026, 07:55 PM |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements three PDS-side
com.atproto.identity.*endpoints that previously fell through to the AppView proxy and returned 501. Each follows the existingresolveHandlepattern: serve the local account directly, fall through to the proxy for foreign identities.resolveDid— returns{didDoc}for our local DID; foreign DIDs fall through to the AppView proxy.resolveIdentity— returns{did, handle, didDoc}for our local handle or DID; foreign identifiers fall through.getRecommendedDidCredentials(authenticated) — returnsrotationKeys,alsoKnownAs,verificationMethods, and theatproto_pdsservice entry, used by other PDSes during inbound migration. The signing key is derived fromSIGNING_KEYviaSecp256k1Keypair.import().did().Also extracts the DID document construction (previously inlined in
/.well-known/did.json) into a sharedbuildDidDocument(env)helper so the well-known route and the new XRPC routes return identical documents.Test plan
pnpm --filter @getcirrus/pds test— 303 unit + 84 CLI tests pass, including 9 new tests intest/identity.test.tscovering each endpoint's happy path, missing-param 400s, fall-through for foreign identifiers, and auth enforcement ongetRecommendedDidCredentials.pnpm --filter @getcirrus/pds check— publint + attw clean.