fix(pds): session auth + lexicon polish#180
Merged
Merged
Conversation
- getSession now accepts DPoP-bound OAuth tokens (RFC 9449), not just Bearer - listAppPasswords returns createdAt as RFC 3339, not SQLite datetime format - Implement getAccountInviteCodes (was 501 via AppView proxy fallthrough)
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
pdscheck | 8de3fe7 | May 24 2026, 07:56 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
atproto-pds | 8de3fe7 | May 24 2026, 07:56 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cirrusdocs | 8de3fe7 | Commit Preview URL Branch Preview URL |
May 24 2026, 07:56 PM |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small conformance fixes found by pdscheck running against a live Cirrus deployment.
getSessionaccepts DPoP-bound tokens. The handler hard-codedif (!authHeader?.startsWith("Bearer ")) → 401, so OAuth clients presentingAuthorization: DPoP <jwt>(RFC 9449) could never read their own session. It now triesprovider.verifyAccessToken(c.req.raw)first — the same pathmiddleware/auth.tsalready uses — and falls through to the staticAUTH_TOKENand JWT-secret paths.listAppPasswordsreturns RFC 3339 datetimes. The column is populated by SQLite'sdatetime('now'), which produces"2026-03-29 15:30:17"— not a valid lexicon datetime. Fixed at the storage boundary so the application code keeps getting an ISO string regardless of how the value was written.getAccountInviteCodesreturns{codes: []}. The endpoint wasn't registered, so unknown XRPC methods fell through to the AppView proxy and returned 501. Cirrus hasinviteCodeRequired: false, so an empty list is the correct, lexicon-conformant response. Endpoint requires auth like the other authenticated server.* routes.Test plan
pnpm --filter @getcirrus/pds test(297 unit + 84 CLI tests pass, including 3 new tests covering the fixes)pnpm --filter @getcirrus/pds checkpassesgetSessionreturns 200 for a stored OAuth access tokenlistAppPasswords.createdAtparses as an ISO timestampgetAccountInviteCodesreturns 200 +{codes: []}when authed, 401 when not