chore: drop non-PDS endpoints from PDS and pdscheck#187
Merged
Conversation
resolveDid, resolveIdentity, and listReposByCollection are directory and relay lexicons, not PDS endpoints. The reference @atproto PDS doesn't implement them either — they fall through to the AppView proxy. Removes the Cirrus handlers, the now-orphaned rpcHasRecordsInCollection RPC, and the matching pdscheck checks that were treating them as required PDS methods.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
pdscheck | a04ba19 | May 25 2026, 06:31 AM |
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cirrusdocs | a04ba19 | Commit Preview URL Branch Preview URL |
May 25 2026, 06:31 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
atproto-pds | a04ba19 | May 25 2026, 06:31 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.atproto.identity.resolveDid,com.atproto.identity.resolveIdentity, andcom.atproto.sync.listReposByCollectionhandlers from the Cirrus PDS. These are directory / relay lexicons — the reference @atproto PDS doesn't implement them either (noresolveDid.ts/resolveIdentity.ts/listReposByCollection.tsinpackages/pds/src/api). Requests now fall through to the AppView proxy like any other unknown method.identity.pds-resolve-did,identity.pds-resolve-identity,sync.list-repos-by-collectionand their.validatescompanions). They were asserting these endpoints exist and are unauthenticated against an arbitrary PDS host, which has no spec basis — pdscheck against jay.bsky.team / morel.us-east.host.bsky.network returnedAuthMissingfor all three.rpcHasRecordsInCollectionDurable Object RPC.buildDidDocumentstays —/.well-known/did.jsonstill uses it.Test plan
pnpm -F @getcirrus/pds test— 302 unit + 84 CLI tests passpnpm -F @getcirrus/pds check— publint + attw cleanpnpm -F @getcirrus/check check— tsc cleanpnpm -F @getcirrus/check build— builds