fix(oauth): correct response_mode default and add userinfo endpoint #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
atproto-pds | 677f2db | Jan 05 2026, 10:21 PM |
commit: |
- Fix default response_mode from "fragment" to "query" for authorization code flow per RFC 6749. This allows server-side apps to receive the authorization code in the query string instead of the URL fragment. - Add /oauth/userinfo endpoint that returns the user's DID (sub) and handle (preferred_username) after validating the access token. - Add private_key_jwt client authentication support (RFC 7523) for confidential OAuth clients, with full JWT assertion validation. - Add userinfo_endpoint to OAuth server metadata for client discovery. Fixes #73
ascorbic
force-pushed
the
fix/oauth-response-mode-and-userinfo
branch
from
d9bb353 to
677f2db
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #73 - Login denied on pckt.blog
Fix
response_modedefault: Changed fromfragmenttoqueryfor authorization code flow per RFC 6749. Server-side apps can now receive the authorization code in the query string (?code=...) instead of the URL fragment (#code=...).Add
/oauth/userinfoendpoint: Returns the user's DID (sub) and handle (preferred_username) for OpenID Connect compatibility. This endpoint is required by some OAuth clients after token exchange.Add
private_key_jwtclient authentication: Implements RFC 7523 JWT Bearer client authentication for confidential OAuth clients, with inline JWKS and remote JWKS URI support.Test plan