Packaging overhaul#670
Conversation
Now that we're not using astropy_helpers anymore, we need a different way to provide the package version.
It's not clear whether this is actually necessary but it preserves the previous behavior.
This test was making an invalid assumption about file size rather than comparing the contents of the exploded/imploded files themselves.
|
Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
3 similar comments
|
Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
|
Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
|
Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
==========================================
+ Coverage 93.24% 93.29% +0.04%
==========================================
Files 39 39
Lines 4295 4295
==========================================
+ Hits 4005 4007 +2
+ Misses 290 288 -2
Continue to review full report at Codecov.
|
drdavella
force-pushed
the
packaging-overhaul
branch
from
af8451b to
f5c1573
Compare
2 participants
This overhauls the packaging infrastructure. It does away with
astropy_helpersonce and for all. It also adds apyproject.tomlfile and moves nearly allsetuptoolsconfiguration tosetup.cfg.This also fixes #667.