add two converter tutorials#11
Conversation
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, |
There was a problem hiding this comment.
This PR is adding output to these old notebooks, is that intentional?
There was a problem hiding this comment.
No, I wonder how that happened.
| "Python primative types (e.g., strings, numbers, booleans,\n", | ||
| "lists and dictionaries), as well as objects that have \n", | ||
| "serialization defined (e.g., astropy models and GWCS).\n", | ||
| "For example, if you define a class that has as one of\n", |
There was a problem hiding this comment.
There's a subtlety to this, which is that the containing class's converter could be coded up to also handle the other class instance. Probably not worth getting into?
There was a problem hiding this comment.
Yeah, I'd rather avoid exploding their heads this time around.
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "mkdir src/myschemas/resources" |
There was a problem hiding this comment.
This is different from the structure created by the cookiecutter template, which puts the resources directory in the repo root.
There was a problem hiding this comment.
Hmmm, we seemed to have done it this way for rad. Should we have not done that?
|
These look good. I only read them, haven't run the yet. Also checkout the notebooks for the first tutorials to remove the changes that appear here. |
|
I think |
4 participants
As it says, two converter tutorials have been added. The first does not use schemas, the second does.