Tweaked some punctuation and wording.#9
Merged
perrygreenfield merged 1 commit intoasdf-format:masterfrom Dec 9, 2020
Merged
Conversation
|
I'll check with Ed on that. |
perrygreenfield
approved these changes
Dec 9, 2020
The asdf library does validate all tagged objects (that have schemas) when it reads a file. But it doesn't know about the DataModel schema, since that schema applies to the tree as a whole and does not correspond to a tag. That's a peculiarity of stdatamodels so I think the statement about asdf is correct. |
|
Righto. That's one consequence of the existing JWST data model scheme that would change with what I'm proposing with using tags. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also fixed some typos. I stopped reviewing this at the following line (which I think may not be presently accurate):
"This checking is called validation and it is by default, performed when reading ASDF files, as well as writing content to them. "
In my Roman work, I have to manually validate all DataModels - which I am not sure is due to an issue in ASDF or STDatamodels.