Conversation
reweeden
force-pushed
the
rew/cumulus-helpers
branch
3 times, most recently
from
b5079f7 to
325ec69
Compare
reweeden
force-pushed
the
rew/cumulus-helpers
branch
from
2dbdef0 to
ac9eead
Compare
reweeden
force-pushed
the
rew/cumulus-helpers
branch
3 times, most recently
from
f23df4f to
c06e7aa
Compare
gjclark
approved these changes
Oct 14, 2024
mattp0
reviewed
Oct 14, 2024
reweeden
force-pushed
the
rew/cumulus-helpers
branch
from
c06e7aa to
34fbb89
Compare
mattp0
approved these changes
Oct 14, 2024
mckadesorensen
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the Zarr sidecar file generation we need to be able to duplicate some core cumulus functionality. In particular we need to be able to get the final destination bucket / key where
MoveGranuleswill place a particular file.This requires:
url_pathexpression on the cumulus collection object to generate the final key prefixfileslist on the cumulus collection object to find the block that matches a particular file nameThese helpers encapsulate some core cumulus functionality that allow us to do that. For things that are more or less a direct port of some cumulus code, I tried to organize the module structure so that it resembles the module structure in the cumulus repo.
I have skipped porting over some capabilities that we aren't making use of at the moment and raise
NotImplementedErrors instead. If we ever do make use of those features we can come back and figure out those implementations.