Merged
Conversation
reweeden
force-pushed
the
rew/pr-6293-cmr-storage
branch
14 times, most recently
from
f456d32 to
1a8e590
Compare
reweeden
force-pushed
the
rew/pr-6293-cmr-storage
branch
2 times, most recently
from
1ed8258 to
896d6bf
Compare
reweeden
force-pushed
the
rew/pr-6293-cmr-storage
branch
2 times, most recently
from
0b3c379 to
8466134
Compare
reweeden
force-pushed
the
rew/pr-6293-cmr-storage
branch
from
8466134 to
a4c9f08
Compare
gjclark
approved these changes
Dec 11, 2024
mckadesorensen
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new storage type for making HTTP requests via
requests. There is also a convenience class with a few special parameters that are intended to make passing the CMR configuration a bit nicer.In order to make this actually usable we also needed to add some way of injecting dynamic values into the objects returned from the source configuration. We implement that internally with a new class called
ContextValuewhich is a placeholder containing a jsonpath where a value should be pulled from theContextobject.The syntax we use for defining a context value in the source config is a
$at the start of a string. This can be escaped like this$$in which case the string will be interpreted as a literal string starting with a single$. For example$.meta.foowill become aContextValue(path="$.meta.foo"), however$$.meta.foowill become the string$.meta.foo.