Conversation
gjclark
approved these changes
Feb 25, 2025
reweeden
reviewed
Feb 26, 2025
Contributor
reweeden
left a comment
reweeden
left a comment
There was a problem hiding this comment.
Same comments as here
Summary:
- Too many bullets, we should trim the list down to the essentials that we actually need to solve some problem rather than going with a kitchen sink approach
- The grammar/voice of the bullets should be consistent
.github/pull_request_template.md
Outdated
Comment on lines
8
to
9
| - [ ] I have deployed my code. | ||
| - [ ] All new and existing E2E/Integration tests passed. |
Contributor
There was a problem hiding this comment.
Not applicable, this is a library, there are no end to end tests and no deployment. Testing is done via unit tests.
Suggested change
| - [ ] I have deployed my code. | |
| - [ ] All new and existing E2E/Integration tests passed. |
.github/pull_request_template.md
Outdated
| - [ ] Resources and Data Structures are sorted by ABC or a defined sorting pattern. | ||
| - [ ] Code requirements are pinned. | ||
| - [ ] I have updated the documentation accordingly. | ||
| - [ ] All new and existing unit tests passed. |
Contributor
There was a problem hiding this comment.
This is already checked by the Actions. It shouldn't be in the PR checklist as it will just get out of sync with what is actually true, and it is just an extra task for a human to do that is already handled automatically.
Suggested change
| - [ ] All new and existing unit tests passed. |
mattp0
force-pushed
the
mrp/feat/add-pr-checklist
branch
from
a189517 to
e0cfd63
Compare
mckadesorensen
approved these changes
Feb 28, 2025
mattp0
force-pushed
the
mrp/feat/add-pr-checklist
branch
from
91920b8 to
2796652
Compare
reweeden
reviewed
Mar 3, 2025
.github/pull_request_template.md
Outdated
| - Resources and Data Structures are sorted by ABC or a defined sorting pattern | ||
| - [ ] updated the documentation accordingly | ||
| - [ ] verified required action checks are passing | ||
| - [ ] deployed my code |
Contributor
There was a problem hiding this comment.
Suggested change
| - [ ] deployed my code |
mattp0
force-pushed
the
mrp/feat/add-pr-checklist
branch
from
2796652 to
530fa9b
Compare
reweeden
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.