Skip to content

Rename record_builder parameter to extra_factory#41

Merged
reweeden merged 1 commit intomainfrom
rew/parameter-rename
Mar 19, 2025
Merged

Rename record_builder parameter to extra_factory#41
reweeden merged 1 commit intomainfrom
rew/parameter-rename

Conversation

@reweeden
Copy link
Contributor

@reweeden reweeden commented Mar 12, 2025

The name old name was a little misleading since in the logging module 'record' would be assumed to mean LogRecord, which is not the case here. There is a separate class for creating the LogRecord.

Pull Request Checklist

I have:

  • performed a self review of my code I&A code style
    • Resources and Data Structures are sorted by ABC or a defined sorting pattern
  • updated the documentation accordingly
  • verified required action checks are passing
  • bumped the version number as appropriate

@reweeden reweeden changed the title Rename record_builder to extra_factory Rename record_builder parameter to extra_factory Mar 12, 2025
@reweeden reweeden requested review from gjclark and mattp0 March 12, 2025 16:51
@reweeden reweeden marked this pull request as ready for review March 12, 2025 19:02
@reweeden reweeden force-pushed the rew/parameter-rename branch from 14595d3 to 5e7e552 Compare March 19, 2025 15:42
@reweeden reweeden merged commit 13dbfa8 into main Mar 19, 2025
9 checks passed
@reweeden reweeden deleted the rew/parameter-rename branch March 19, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants