Skip to content

Correct JSON typing and support#42

Merged
reweeden merged 3 commits intomainfrom
rew/full-json-support
Mar 19, 2025
Merged

Correct JSON typing and support#42
reweeden merged 3 commits intomainfrom
rew/full-json-support

Conversation

@reweeden
Copy link
Contributor

@reweeden reweeden commented Mar 12, 2025

Our type annotations and 'basic' querying functionality were assuming that parsed JSON documents would always start with a top level dict. This updates the annotations to allow any valid JSON document including ones that have a top level list or are simply a single primitive value. I also implemented a basic [] syntax to support list indexing when jsonpath_ng is not installed.

Pull Request Checklist

I have:

  • performed a self review of my code I&A code style
    • Resources and Data Structures are sorted by ABC or a defined sorting pattern
  • updated the documentation accordingly
  • verified required action checks are passing
  • bumped the version number as appropriate

@reweeden reweeden requested review from gjclark and mattp0 March 12, 2025 18:53
@reweeden reweeden marked this pull request as ready for review March 12, 2025 19:01
@reweeden reweeden force-pushed the rew/full-json-support branch from 5f5d675 to 800c482 Compare March 19, 2025 15:26
@reweeden reweeden force-pushed the rew/full-json-support branch from 800c482 to ed6c317 Compare March 19, 2025 15:34
@reweeden reweeden merged commit 84b958a into main Mar 19, 2025
9 checks passed
@reweeden reweeden deleted the rew/full-json-support branch March 19, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants