Skip to content

fix(react): fix SignUp component issues with AsgardeoV2 + Password field display issues #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brionmario merged 8 commits into from
Nov 11, 2025
Merged

fix(react): fix SignUp component issues with AsgardeoV2 + Password field display issues #237

brionmario merged 8 commits into from
Nov 11, 2025

Conversation

@brionmario
Copy link
Member

@brionmario brionmario commented Nov 7, 2025 •
edited
Loading

Purpose

  • Fix SignUp component issues with AsgardeoV2
    • Properly showing error messages
    • Add missing i18n
  • Fix Password field display issue in SignIn component
    • Password was rendered as a normal text field.

Related Issues

Related PRs

  • N/A

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

@brionmario brionmario changed the title feat(i18n): add sign-up error messages and update translations for mu… fix(react): fix SignUp component issues with AsgardeoV2 Nov 7, 2025
@brionmario brionmario changed the title fix(react): fix SignUp component issues with AsgardeoV2 fix(react): fix SignUp component issues with AsgardeoV2 + Password field display issues Nov 11, 2025
DonOmalVindula
DonOmalVindula previously approved these changes Nov 11, 2025
View reviewed changes
@asgardeo-github-bot
Copy link

asgardeo-github-bot commented Nov 11, 2025

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario brionmario merged commit d616b7b into asgardeo:main Nov 11, 2025
3 of 6 checks passed
@asgardeo-github-bot asgardeo-github-bot mentioned this pull request Nov 11, 2025
Merged
@brionmario brionmario mentioned this pull request Nov 11, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DonOmalVindula DonOmalVindula DonOmalVindula approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Password field is rendered as a normal text field

3 participants

@brionmario @asgardeo-github-bot @DonOmalVindula