Skip to content

Conversation

@brionmario
Copy link
Member

Purpose

This pull request refactors the Sign In UI components to improve flexibility, error handling, and consistency between component-driven and non-component-driven implementations. The most significant changes include the addition of new props to control the display of the logo, title, and subtitle, a migration to a unified error message handling system, and a general cleanup of redundant code and props.

Component flexibility and UI consistency:

  • Added showLogo, showTitle, and showSubtitle props to both component-driven and non-component-driven BaseSignIn components, allowing consumers to control the visibility of these elements for greater UI customization. [1] [2] [3] [4] [5]
  • Updated the rendering logic in BaseSignInContent to conditionally display the logo, title, and subtitle based on these new props.

Error handling improvements:

  • Migrated error handling to use the extractErrorMessage transformer and the flow message system, removing the local error state and related props from BaseSignIn and its render props. This ensures errors are displayed consistently and are easier to manage. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Styling and layout adjustments:

  • Updated styles in BaseSignIn.styles.ts to improve layout, including changes to margins and alignment for logo, header, subtitle, and flow messages containers. [1] [2] [3]
  • Removed the redundant non-component-driven/BaseSignIn.styles.ts file and updated imports to use the shared styles for consistency. [1] [2]

Code cleanup and minor improvements:

  • Simplified async return statements in SignIn.tsx for clarity. [1] [2]
  • Updated the sign in subtitle translation for a more welcoming message.

These changes collectively enhance the modularity, maintainability, and user experience of the Sign In components.

Related Issues

Related PRs

  • N/A

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

@asgardeo-github-bot
Copy link

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario brionmario merged commit 6680a97 into asgardeo:main Nov 14, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants