Handle authorization code for V2 platform via AsgardeoProvider
#265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
ThaminduDilshan
approved these changes
Nov 28, 2025
| // If non-V2 platform, use traditional OAuth callback handling | ||
| await signIn( | ||
| {callOnlyOnRedirect: true}, | ||
| // authParams?.authorizationCode, |
Contributor
There was a problem hiding this comment.
Shall we remove the commented code if not needed?
Contributor
Author
There was a problem hiding this comment.
Not handling it in this PR here since it was existing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the authentication flow handling in the
AsgardeoProvidercomponent to support both Asgardeo V2 and non-V2 platforms. The main change is to properly differentiate between embedded flows and traditional OAuth flows for V2, ensuring that the sign-in process is triggered only when appropriate.Authentication flow improvements:
AsgardeoProvider.tsx, the logic for handling authentication parameters on redirect now checks for the V2 platform and distinguishes between embedded and traditional OAuth flows. For V2, it exchanges the OAuth code for tokens only if there is noflowIdpresent in the URL or session storage, otherwise it follows the traditional OAuth callback for non-V2 platforms.