Skip to content

fix: properly throw JWT verification errors #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brionmario merged 2 commits into from
Dec 1, 2025
Merged

fix: properly throw JWT verification errors #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7c548a
fix: throw JWT verification errors
brionmario Dec 1, 2025
a035bed
chore: add changeset 🦋
brionmario Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/gentle-swans-sleep.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@asgardeo/javascript': patch
'@asgardeo/react': patch
---

Throw JWT verification errors
3 changes: 3 additions & 0 deletions packages/javascript/src/IsomorphicCrypto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,9 @@ export class IsomorphicCrypto<T = any> {
'ID token validation returned false',
),
);
})
.catch((error: AsgardeoAuthException) => {
return Promise.reject(error);
});
}

Expand Down
20 changes: 14 additions & 6 deletions packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,12 @@ const AsgardeoProvider: FC<PropsWithChildren<AsgardeoProviderProps>> = ({
}
// setError(null);
} catch (error) {
if (error && Object.prototype.hasOwnProperty.call(error, 'code')) {
// setError(error);
}
throw new AsgardeoRuntimeError(
`Sign in failed: ${error instanceof Error ? error.message : String(JSON.stringify(error))}`,
'asgardeo-signIn-Error',
'react',
'An error occurred while trying to sign in.',
);
}
} else {
// TODO: Add a debug log to indicate that the user is not signed in
Expand Down Expand Up @@ -418,7 +421,12 @@ const AsgardeoProvider: FC<PropsWithChildren<AsgardeoProviderProps>> = ({

return response as User;
} catch (error) {
throw new Error(`Error while signing in: ${error instanceof Error ? error.message : String(error)}`);
throw new AsgardeoRuntimeError(
`Sign in failed: ${error instanceof Error ? error.message : String(JSON.stringify(error))}`,
'asgardeo-signIn-Error',
'react',
'An error occurred while trying to sign in.',
);
} finally {
if (!isV2FlowRequest) {
setIsUpdatingSession(false);
Expand All @@ -440,7 +448,7 @@ const AsgardeoProvider: FC<PropsWithChildren<AsgardeoProviderProps>> = ({
return response;
} catch (error) {
throw new AsgardeoRuntimeError(
`Error while signing in silently: ${error.message || error}`,
`Error while signing in silently: ${error instanceof Error ? error.message : String(JSON.stringify(error))}`,
'asgardeo-signInSilently-Error',
'react',
'An error occurred while trying to sign in silently.',
Expand All @@ -462,7 +470,7 @@ const AsgardeoProvider: FC<PropsWithChildren<AsgardeoProviderProps>> = ({
}
} catch (error) {
throw new AsgardeoRuntimeError(
`Failed to switch organization: ${error.message || error}`,
`Failed to switch organization: ${error instanceof Error ? error.message : String(JSON.stringify(error))}`,
'asgardeo-switchOrganization-Error',
'react',
'An error occurred while switching to the specified organization.',
Expand Down
Loading