Stop resolving i18n keys in render props
#298
Merged
+29
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the
@asgardeo/reactpackage to allow consumers to control whether translation strings are resolved or left as i18n keys when using render props. The main change is the introduction of a new option,resolveTranslations, in the flow transformation utilities and their usage in sign-in and sign-up components. This gives more flexibility to consumers who need to handle translations differently, especially in advanced use cases with custom rendering.Flow transformation and translation handling improvements:
resolveTranslationsoption to theFlowTransformOptionsinterface and updated thetransformComponentsandnormalizeFlowResponsefunctions inflowTransformer.tsto support optionally resolving translation strings or keeping i18n keys. [1] [2] [3]SignInandBaseSignUpContentcomponents to setresolveTranslations: !children, so translations are only resolved when not using render props (i.e., whenchildrenis not provided). [1] [2] [3] [4]Documentation and release notes:
Related Issues
asgardeo/thunderruntime #212Related PRs
Checklist
Security checks