Fix required field error and retain previous inputs for validation failures in accept invite component#407
Merged
thiva-k merged 2 commits intoasgardeo:mainfrom Mar 18, 2026
Conversation
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
brionmario
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements to the
BaseAcceptInvitecomponent, primarily focusing on form validation, error messaging, and code simplification. The changes enhance user feedback for required fields, improve form state management, and simplify how form components are rendered.Screen.Recording.2026-03-18.at.11.56.13.mov
Form validation and error handling improvements:
t('validations.required.field.error')) for error messages, enabling localization and consistency in user feedback.t, ensuring error messages are updated if the language changes.isFormValidbefore updating error states for better UI consistency.isFormValidtotruewhen errors are cleared, ensuring the form is marked as valid only when appropriate.isFormValidtotrueon submit, relying on validation logic instead.Form state management:
Code simplification:
renderComponentscallback and now directly callrenderInviteUserComponentsin the render method, reducing indirection and making the code easier to follow. [1] [2]