Skip to content

Fix NPEs #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

Fix NPEs #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6e5838
Fix NPEs
brionmario Jun 30, 2025
11fac1d
Refactor exports in index files for better organization and clarity
brionmario Jun 30, 2025
3851019
Add changeset for patch updates to @asgardeo/nextjs and @asgardeo/rea…
brionmario Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/olive-doodles-allow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@asgardeo/nextjs': patch
'@asgardeo/react': patch
---

Fix NPEs
1 change: 1 addition & 0 deletions packages/browser/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,5 @@ export {default as hasAuthParamsInUrl} from './utils/hasAuthParamsInUrl';

export {default as AsgardeoBrowserClient} from './AsgardeoBrowserClient';

// Re-export everything from the JavaScript package
export * from '@asgardeo/javascript';
26 changes: 14 additions & 12 deletions packages/javascript/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,20 @@ export {default as executeEmbeddedSignUpFlow} from './api/executeEmbeddedSignUpF
export {default as getUserInfo} from './api/getUserInfo';
export {default as getScim2Me, GetScim2MeConfig} from './api/getScim2Me';
export {default as getSchemas, GetSchemasConfig} from './api/getSchemas';
export {default as getAllOrganizations} from './api/getAllOrganizations';
export {default as createOrganization} from './api/createOrganization';
export {default as getMeOrganizations} from './api/getMeOrganizations';
export {default as getOrganization} from './api/getOrganization';
export {default as updateOrganization, createPatchOperations} from './api/updateOrganization';
export {default as updateMeProfile} from './api/updateMeProfile';
export type {PaginatedOrganizationsResponse, GetAllOrganizationsConfig} from './api/getAllOrganizations';
export type {CreateOrganizationPayload, CreateOrganizationConfig} from './api/createOrganization';
export type {GetMeOrganizationsConfig} from './api/getMeOrganizations';
export type {OrganizationDetails, GetOrganizationConfig} from './api/getOrganization';
export type {UpdateOrganizationConfig} from './api/updateOrganization';
export type {UpdateMeProfileConfig} from './api/updateMeProfile';
export {
default as getAllOrganizations,
PaginatedOrganizationsResponse,
GetAllOrganizationsConfig,
} from './api/getAllOrganizations';
export {
default as createOrganization,
CreateOrganizationPayload,
CreateOrganizationConfig,
} from './api/createOrganization';
export {default as getMeOrganizations, GetMeOrganizationsConfig} from './api/getMeOrganizations';
export {default as getOrganization, OrganizationDetails, GetOrganizationConfig} from './api/getOrganization';
export {default as updateOrganization, createPatchOperations, UpdateOrganizationConfig} from './api/updateOrganization';
export {default as updateMeProfile, UpdateMeProfileConfig} from './api/updateMeProfile';

export {default as ApplicationNativeAuthenticationConstants} from './constants/ApplicationNativeAuthenticationConstants';
export {default as TokenConstants} from './constants/TokenConstants';
Expand Down
40 changes: 20 additions & 20 deletions packages/react/src/components/presentation/SignIn/BaseSignIn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ const BaseSignInContent: FC<BaseSignInProps> = ({
*/
const handleRedirectionIfNeeded = (response: EmbeddedSignInFlowHandleResponse): boolean => {
if (
'nextStep' in response &&
response && 'nextStep' in response &&
response.nextStep &&
(response.nextStep as any).stepType === EmbeddedSignInFlowStepType.AuthenticatorPrompt &&
(response.nextStep as any).authenticators &&
Expand Down Expand Up @@ -563,7 +563,7 @@ const BaseSignInContent: FC<BaseSignInProps> = ({

onFlowChange?.(response);

if (response.flowStatus === EmbeddedSignInFlowStatus.SuccessCompleted) {
if (response?.flowStatus === EmbeddedSignInFlowStatus.SuccessCompleted) {
onSuccess?.(response.authData);
}
}
Expand Down Expand Up @@ -618,14 +618,14 @@ const BaseSignInContent: FC<BaseSignInProps> = ({
});
onFlowChange?.(response);

if (response.flowStatus === EmbeddedSignInFlowStatus.SuccessCompleted) {
if (response?.flowStatus === EmbeddedSignInFlowStatus.SuccessCompleted) {
onSuccess?.(response.authData);
return;
}

if (
response.flowStatus === EmbeddedSignInFlowStatus.FailCompleted ||
response.flowStatus === EmbeddedSignInFlowStatus.FailIncomplete
response?.flowStatus === EmbeddedSignInFlowStatus.FailCompleted ||
response?.flowStatus === EmbeddedSignInFlowStatus.FailIncomplete
) {
setError(t('errors.sign.in.flow.completion.failure'));
return;
Expand All @@ -636,7 +636,7 @@ const BaseSignInContent: FC<BaseSignInProps> = ({
return;
}

if ('flowId' in response && 'nextStep' in response) {
if (response && 'flowId' in response && 'nextStep' in response) {
const nextStepResponse = response as any;
setCurrentFlow(nextStepResponse);

Expand Down Expand Up @@ -718,21 +718,21 @@ const BaseSignInContent: FC<BaseSignInProps> = ({
});
onFlowChange?.(response);

if (response.flowStatus === EmbeddedSignInFlowStatus.SuccessCompleted) {
if (response?.flowStatus === EmbeddedSignInFlowStatus.SuccessCompleted) {
onSuccess?.(response.authData);
return;
}

if (
response.flowStatus === EmbeddedSignInFlowStatus.FailCompleted ||
response.flowStatus === EmbeddedSignInFlowStatus.FailIncomplete
response?.flowStatus === EmbeddedSignInFlowStatus.FailCompleted ||
response?.flowStatus === EmbeddedSignInFlowStatus.FailIncomplete
) {
setError(t('errors.sign.in.flow.passkeys.completion.failure'));
return;
}

// Handle next step if authentication is not complete
if ('flowId' in response && 'nextStep' in response) {
if (response && 'flowId' in response && 'nextStep' in response) {
const nextStepResponse = response as any;
setCurrentFlow(nextStepResponse);

Expand Down Expand Up @@ -795,7 +795,7 @@ const BaseSignInContent: FC<BaseSignInProps> = ({
});
onFlowChange?.(response);

if (response.flowStatus === EmbeddedSignInFlowStatus.SuccessCompleted) {
if (response?.flowStatus === EmbeddedSignInFlowStatus.SuccessCompleted) {
onSuccess?.(response.authData);
return;
}
Expand Down Expand Up @@ -823,14 +823,14 @@ const BaseSignInContent: FC<BaseSignInProps> = ({
});
onFlowChange?.(response);

if (response.flowStatus === EmbeddedSignInFlowStatus.SuccessCompleted) {
if (response?.flowStatus === EmbeddedSignInFlowStatus.SuccessCompleted) {
onSuccess?.(response.authData);
return;
}

if (
response.flowStatus === EmbeddedSignInFlowStatus.FailCompleted ||
response.flowStatus === EmbeddedSignInFlowStatus.FailIncomplete
response?.flowStatus === EmbeddedSignInFlowStatus.FailCompleted ||
response?.flowStatus === EmbeddedSignInFlowStatus.FailIncomplete
) {
setError('Authentication failed. Please check your credentials and try again.');
return;
Expand All @@ -841,7 +841,7 @@ const BaseSignInContent: FC<BaseSignInProps> = ({
return;
}

if ('flowId' in response && 'nextStep' in response) {
if (response && 'flowId' in response && 'nextStep' in response) {
const nextStepResponse = response as any;
setCurrentFlow(nextStepResponse);

Expand Down Expand Up @@ -894,14 +894,14 @@ const BaseSignInContent: FC<BaseSignInProps> = ({
});
onFlowChange?.(response);

if (response.flowStatus === EmbeddedSignInFlowStatus.SuccessCompleted) {
if (response?.flowStatus === EmbeddedSignInFlowStatus.SuccessCompleted) {
onSuccess?.(response.authData);
return;
}

if (
response.flowStatus === EmbeddedSignInFlowStatus.FailCompleted ||
response.flowStatus === EmbeddedSignInFlowStatus.FailIncomplete
response?.flowStatus === EmbeddedSignInFlowStatus.FailCompleted ||
response?.flowStatus === EmbeddedSignInFlowStatus.FailIncomplete
) {
setError('Authentication failed. Please try again.');
return;
Expand All @@ -912,7 +912,7 @@ const BaseSignInContent: FC<BaseSignInProps> = ({
return;
}

if ('flowId' in response && 'nextStep' in response) {
if (response && 'flowId' in response && 'nextStep' in response) {
const nextStepResponse = response as any;
setCurrentFlow(nextStepResponse);

Expand Down Expand Up @@ -952,7 +952,7 @@ const BaseSignInContent: FC<BaseSignInProps> = ({
}
}
} catch (err) {
const errorMessage = err instanceof AsgardeoAPIError ? err.message : 'Authenticator selection failed';
const errorMessage = err instanceof AsgardeoAPIError ? err?.message : 'Authenticator selection failed';
setError(errorMessage);
onError?.(err as Error);
} finally {
Expand Down
22 changes: 7 additions & 15 deletions packages/react/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,20 +243,12 @@ export type {FlowStep, FlowMessage, FlowContextValue} from './contexts/Flow/Flow

export type {FlowProviderProps} from './contexts/Flow/FlowProvider';


export {default as getAllOrganizations} from './api/getAllOrganizations';
export {default as createOrganization} from './api/createOrganization';
export {default as getMeOrganizations} from './api/getMeOrganizations';
export {default as getOrganization} from './api/getOrganization';
export {default as updateOrganization, createPatchOperations} from './api/updateOrganization';
export {default as getSchemas} from './api/getSchemas';
export {default as updateMeProfile} from './api/updateMeProfile';
export type {GetAllOrganizationsConfig} from './api/getAllOrganizations';
export type {CreateOrganizationConfig} from './api/createOrganization';
export type {GetMeOrganizationsConfig} from './api/getMeOrganizations';
export type {GetOrganizationConfig} from './api/getOrganization';
export type {UpdateOrganizationConfig} from './api/updateOrganization';
export type {GetSchemasConfig} from './api/getSchemas';
export type {UpdateMeProfileConfig} from './api/updateMeProfile';
export {default as getAllOrganizations, GetAllOrganizationsConfig} from './api/getAllOrganizations';
export {default as createOrganization, CreateOrganizationConfig} from './api/createOrganization';
export {default as getMeOrganizations, GetMeOrganizationsConfig} from './api/getMeOrganizations';
export {default as getOrganization, GetOrganizationConfig} from './api/getOrganization';
export {default as updateOrganization, createPatchOperations, UpdateOrganizationConfig} from './api/updateOrganization';
export {default as getSchemas, GetSchemasConfig} from './api/getSchemas';
export {default as updateMeProfile, UpdateMeProfileConfig} from './api/updateMeProfile';
export {default as getMeProfile} from './api/getScim2Me';
export * from './api/getScim2Me';
Loading