fix: aggregates to_tenant support#2487
Merged
zachdaniel merged 1 commit intoash-project:mainfrom Jan 20, 2026
Merged
Conversation
Contributor
Author
|
@zachdaniel anything I can do to move this forward ? (sorry for the ping but I feel like this slipped through because I had the bad idea to push on christmas eve 😄 ) |
Contributor
|
🚀 Thank you for your contribution! 🚀 (sorry, lost track of this somehow) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my project I was trying to do an
Ash.count!()with a struct astenantargument and it would fail with an error telling me the tenant struct doesn't implementStrings.Charsprotocol, the issue being thatto_tenantwasn't passed correctly, this fixes that.I took the liberty to remove that
tenantvariable in thereduce_whileas it seems it's alwaysquery.tenantand I couldn't understand why it exists.Contributor checklist
Leave anything that you believe does not apply unchecked.