fix: Policy Authorizer strict checking forbid_unless#2678
Merged
zachdaniel merged 1 commit intoash-project:mainfrom Apr 15, 2026
Merged
fix: Policy Authorizer strict checking forbid_unless#2678zachdaniel merged 1 commit intoash-project:mainfrom
zachdaniel merged 1 commit intoash-project:mainfrom
Conversation
forbid_unless checks would not :halt in policy_fails_statically?, causing a subsequent authorize_if to cause the result to be authorized.
zachdaniel
approved these changes
Apr 15, 2026
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2677
forbid_unlesschecks would not:haltinpolicy_fails_statically?, causing a subsequentauthorize_ifto cause the result to be authorized.Contributor checklist
Leave anything that you believe does not apply unchecked.