Skip to content

fix - eager error evaluation in manage_relationship validation#2687

Merged
zachdaniel merged 2 commits intoash-project:mainfrom
RetroDev256:main
Apr 30, 2026
Merged

fix - eager error evaluation in manage_relationship validation#2687
zachdaniel merged 2 commits intoash-project:mainfrom
RetroDev256:main

Conversation

@RetroDev256
Copy link
Copy Markdown
Contributor

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

Summary

Closes #2665

  • manage_relationship validation now collects all errors rather than stopping at the first error.
  • modified functions eagerly evaluate items using reduce instead of reduce_while
  • a regression test case from the original github issue was added
  • some function-local variables were renamed for clarity

@zachdaniel zachdaniel merged commit 20bf5e7 into ash-project:main Apr 30, 2026
49 checks passed
@zachdaniel
Copy link
Copy Markdown
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

manage_relationship validation returns only one error for multiple invalid related records

2 participants