Fix/code interface validation hint#2697
Merged
zachdaniel merged 3 commits intoMay 12, 2026
Merged
Conversation
zachdaniel
reviewed
May 12, 2026
Contributor
|
This looks great! Just had one comment and then we can merge 😄 |
Co-authored-by: Zach Daniel <zachary.s.daniel@gmail.com>
Contributor
Author
|
Thanks for the review! I committed your suggested edit to the branch. |
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
Summary
Resolves #992
Improves code interface validation errors when action params are accidentally passed as a keyword list instead of a params map.
Example of the incorrect call shape:
instead of:
Previously, Ash raised an unknown options error for :first_name even when it was a valid action input. This PR adds a targeted hint explaining the likely mistake and shows the expected call shape.
Behavior
When unknown options are detected, Ash now checks whether those keys are valid action inputs.
If they are, the validation error includes a helpful hint with the proper function usage. Non-input unknown options continue behaving exactly as before.
Tests
Added regression coverage for: