Hardcoded binding fails add_aggregates

[StephanH90]

Code of Conduct

• I agree to follow this project's Code of Conduct

AI Policy

• I agree to follow this project's AI Policy, or I agree that AI was not used while creating this issue.

Versions

ash_sql 0.3.16

Operating system

ubuntu

Current Behavior

When the parent resource has a primary key of integer but the joined resource that is being used for the aggregate has a different type for the primary key such as an uuid it fails.

I think the reason is this line:

# lib/sort.ex:166
case AshSql.Aggregate.add_aggregates(query, used_aggregates, resource, false, 0) do # `0` instead of `binding`

This function receives binding. If I change this to binding instead of 0 the aggregate works fine in my project. Is there a reason why this is 0?

Reproduction

I could only reproduce this in a project using ash_postgres but I think this is the underlying issue.

Expected Behavior

No response

[zachdaniel]

It looks like a bug to me 😄. Want to make a PR? I can do it if not.

[StephanH90]

The PR is just changing 0 to binding but I wouldn't know how to write a test for that :(

I opened a PR but it doesn't have a test yet: #226