Skip to content

Conversation

@ahey
Copy link
Contributor

@ahey ahey commented Dec 2, 2025

When upgrading our project to the latest ash package dependencies, I encountered a bug on an existing feature that was not previously present. The bug was introduced in a recent ash_sql commit.

I have used AI to create a fix for the issue, and also a test that reproduces the issue. I have verified that the test fails on ash_sql main and passes with the fix applied. I was not able to fully understand the fix – it's a small patch and i'm hoping it makes sense to someone with more experience in ash_sql than me. Otherwise, if this cannot be accepted we at least have the failing test I have created in ash_postgres that demonstrates the issue.

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@zachdaniel zachdaniel merged commit 4077cf8 into ash-project:main Dec 3, 2025
23 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants