Skip to content

fix: use mutate repo for queries with locks #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachdaniel merged 2 commits into from
Jun 3, 2026
+20 −10
Merged

fix: use mutate repo for queries with locks #234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d54b32a
fix: use mutate repo for queries with locks
jsw800 Jun 2, 2026
4e2cd2e
fix warning
jsw800 Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions lib/ash_sql.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,32 @@

defmodule AshSql do
@moduledoc false
def dynamic_repo(resource, sql_behaviour, %{
__ash_bindings__: %{context: %{data_layer: %{repo: repo}}}
}) do
repo || sql_behaviour.repo(resource, :read)
def dynamic_repo(
resource,
sql_behaviour,
%{
__ash_bindings__: %{context: %{data_layer: %{repo: repo}}}
} = query
) do
repo || sql_behaviour.repo(resource, repo_type(query))
end

def dynamic_repo(resource, sql_behaviour, %struct{context: %{data_layer: %{repo: repo}}}) do
type = struct_to_repo_type(struct)

repo || sql_behaviour.repo(resource, type)
def dynamic_repo(
resource,
sql_behaviour,
%_{context: %{data_layer: %{repo: repo}}} = query
) do
repo || sql_behaviour.repo(resource, repo_type(query))
end

def dynamic_repo(resource, sql_behaviour, %struct{}) do
sql_behaviour.repo(resource, struct_to_repo_type(struct))
def dynamic_repo(resource, sql_behaviour, query) do
sql_behaviour.repo(resource, repo_type(query))
end

defp repo_type(%{lock: lock}) when not is_nil(lock), do: :mutate
defp repo_type(%struct{}), do: struct_to_repo_type(struct)
defp repo_type(_), do: :read

def repo_opts(_repo, sql_behaviour, timeout, tenant, resource) do
if Ash.Resource.Info.multitenancy_strategy(resource) == :context do
[prefix: tenant]
Expand Down