Skip to content

feat(ci): add mishka_chelekom project to test ci#334

Merged
zachdaniel merged 2 commits intoash-project:mainfrom
shahryarjb:main
Sep 27, 2025
Merged

feat(ci): add mishka_chelekom project to test ci#334
zachdaniel merged 2 commits intoash-project:mainfrom
shahryarjb:main

Conversation

@shahryarjb
Copy link
Copy Markdown
Contributor

@shahryarjb shahryarjb commented Sep 26, 2025

This adds the mishka_chelekom project to the GitHub Actions test matrix in test-projects.yml for CI test.
Because all Mishka Chelekom project tasks are Igniter, i did not add --only igniter like the other

Thank you in advance

This adds the `mishka_chelekom` project to the GitHub Actions test matrix in `test-projects.yml` for CI coverage.
Comment thread .github/workflows/test-projects.yml Outdated
{
org: "mishka-group",
name: "mishka_chelekom",
test-cmd: "mix test",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to only run tests related to the igniter installers, can you add a ---only igniter here and tag the relevant tests? Even if they are all igniter tests at the moment, the point is to make sure igniter's build doesn't fail just because some unrelated test fails in mishka.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zachdaniel Yes, I understand. now my master branch tests have igniter flag and i edited the .github/workflows/test-projects.yml and added mix test --only igniter
Thank you

@zachdaniel zachdaniel merged commit bc284a5 into ash-project:main Sep 27, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants