Skip to content

fix: implements_behaviour? do not return true for any module #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

fix: implements_behaviour? do not return true for any module #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/spark.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ defmodule Spark do

# never seen a module with three behaviours in real life, let alone four.
{:behaviour, behaviours} when is_list(behaviours) ->
module in behaviours
behaviour in behaviours

_ ->
false
Expand Down
15 changes: 15 additions & 0 deletions test/spark_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,19 @@ defmodule SparkTest do
use ExUnit.Case
doctest Spark
doctest Spark.Options

describe inspect(&Spark.implements_behaviour?/2) do
test "returns true if the module implements the specified behavior" do
defmodule TestModule do
@callback foo :: any()

@behaviour TestModule

def foo, do: :ok
end

refute Spark.implements_behaviour?(TestModule, AnyOtherModule)
assert Spark.implements_behaviour?(TestModule, TestModule)
end
end
end