Deal with chronos jobs that have spaces in the name#10
Merged
Conversation
5a93d59 to
b4b0d31
Compare
|
shipit |
Collaborator
Author
|
I don't understand why travis has a green checkmark for the failing test commit. That sha definitly fails the itests and it is not using urlencoded urls: In the output it just has a git checkout of "HEAD", so that run in travis doesn't reflect the actual failing test. In other words, this bug is real and the second commit really fixes it. I'll merge this into our own fork and do an internal release to unblock us. |
asher
added a commit
that referenced
this pull request
Aug 27, 2015
Deal with chronos jobs that have spaces in the name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch correctly will quote the URL when we interact with the chronos api, so it properly deals with characters like spaces in chronos job names (which are perfectly valid chronos job names).
This is analogous to how the actual web interface works when you click the new job button.