Python 3 support#21
Merged
Merged
Conversation
Collaborator
|
hi @navidurrahman.
The integration tests run inside of a Docker Container running 14.04 (see the Dockerfile) , so I'm not sure this will have the consequence you expect - it'll change the host machine Travis provides to run 14.04 rather than 12.04, but the OS in which Chronos is installed and tested will remain the same.
I don't think so?
This is great, thanks! I'm happy to take this patch as is though, I guess it's no harm to use Trusty in Travis? @solarkennedy @asher any comments before I merge? |
Collaborator
|
The itest run in docker if you are running them locally, but on travis they run on "bare metal", whatever travis has. |
Contributor
Author
|
Here is the stack trace of Travis with ubuntu 12: https://travis-ci.org/asher/chronos-python/jobs/110816592 By default, it was selecting ubuntu 12, and couldn't find the Chronos repo. |
Collaborator
|
Yea, I mean the repo is there, just 2.3.4 is not. Can you adjust |
Contributor
Author
|
@solarkennedy Updated the default version of chronos. Looks fine now. |
| payload = content | ||
| except (TypeError, ValueError): | ||
| try: | ||
| payload = json.loads(content.decode('utf-8')) |
Collaborator
There was a problem hiding this comment.
Is there any harm in trying to decode in utf-8 all the time?
navidurrahman
force-pushed
the
python3_support
branch
from
52ad42c to
1fdf3ec
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for python 3 and removed chronos legacy version
Change default chronos version
Python 3 support