Generalize auth token#32
Merged
Merged
Conversation
Collaborator
|
thanks for following up- can you remove the version commit by rebasing? it's out of order atm. I'll merge and release once you've done that. |
hylandm
force-pushed
the
generalize_auth_token
branch
from
15bb63c to
2a9b682
Compare
Collaborator
|
sorry, can you remove the .DS_Store file you've added and release commit entirely? I'll do the release separately once this is merged. |
hylandm
force-pushed
the
generalize_auth_token
branch
from
2a9b682 to
80e6083
Compare
hylandm
force-pushed
the
generalize_auth_token
branch
from
80e6083 to
67cd3ee
Compare
Author
|
Done. Thanks for collaborating. |
Collaborator
|
Thankyou! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These contains the improvements that were asked for in cantenesse's pr. I was unable to figure out how to add a test case though, however I tested this throughly locally (adding a token to auth, adding a bad token, ensuring headers persist with the object.)