Skip to content

Make a hierarchy of exceptions#36

Merged
Rob-Johnson merged 1 commit into
asher:masterfrom
theosotr:exceptions-hierarchy
Mar 23, 2017
Merged

Make a hierarchy of exceptions#36
Rob-Johnson merged 1 commit into
asher:masterfrom
theosotr:exceptions-hierarchy

Conversation

@theosotr
Copy link
Copy Markdown
Contributor

No description provided.

@Rob-Johnson
Copy link
Copy Markdown
Collaborator

only the UnauthorizedError is really a ChronosApiError. The other two are validation errors - happy if you want to make a common exception for those to subclass too?

@theosotr theosotr force-pushed the exceptions-hierarchy branch from e489896 to 13ebad4 Compare March 23, 2017 08:49
@theosotr theosotr changed the title Make all exceptions be subclasses of ChronosApiError Make a hierarchy of exceptions Mar 23, 2017
@theosotr
Copy link
Copy Markdown
Contributor Author

Done!

@Rob-Johnson
Copy link
Copy Markdown
Collaborator

i've run the tests locally to verify the itest failure is just a problem with our travis setup. thanks!

@Rob-Johnson Rob-Johnson merged commit a868442 into asher:master Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants