Run itests in a docker container#6
Merged
Merged
Conversation
Collaborator
There was a problem hiding this comment.
This can't sleep forever, it needs to return right away to allow the next step (tox) to go
Collaborator
|
Looks good! And now a green check-mark. This will be useful to test against api changes with new chronos versions, and it will allow us to run itests with just docker and not installing chronos on my local laptop! |
Owner
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run chronos related itests in a docker container with all the reqs available
Thanks to @solarkennedy for most of the code that was copied over from the marathon-python project