Allow a list of servers to be passed in to the client#7
Merged
Conversation
Collaborator
|
Ooo this is good stuff, very similar to the marathon client library. Nice. |
Contributor
Author
|
This probably constitutes a breaking API change with the rename of the hostname -> servers kwarg |
…nto server-priority-list Conflicts: chronos/__init__.py tests/test_chronos_init.py
Contributor
Author
|
Merges in changes from #9 to prevent Github's auto merge from breaking the code. |
Collaborator
|
Thanks Keshav. @asher it'd be great if we could get this merged. |
Owner
|
@keshavdv would you mind updating the README.md to show an example of passing multiple servers, as in marathon-python/README.md? thanks! |
Conflicts: chronos/__init__.py
Contributor
Author
|
Done and merged master to fix the conflicts. |
asher
added a commit
that referenced
this pull request
Aug 27, 2015
Allow a list of servers to be passed in to the client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to pass in a list of Chronos servers that will be tried in order (to mimic the marathon-python client). Also adds some custom exception classes so that it's easier to try-catch specific things.
Also fixes issue #2.